tty: move from libc to nix
#3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the unsafe from our responsibility to nix and makes the code a bit cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the responsibility for
unsafefrom us tonixand makes the code a bit cleaner as a result.As an optimization, I moved the
isattycheck to before getting the name if the silent option is passed with an early return. The functionality should stay exactly the same.Notes:
is_whitespacecheck. This check has been in the code since the very first commit (f0be827), but it seems to check for the same thing as the error code. So as far as I can tell, it was not necessary now that we have a nice result type fromnix.collect_lossycall because there are only flags, so the handling of invalid encoding doesn't matter.